WT-1891 - cleaned up ReadyToConnect view and SDK (#1103)

immutable · Nov 1, 2023 · 7c029cd · 7c029cd
1 parent 8a86a3c
commit 7c029cd
Show file tree

Hide file tree

Showing 7 changed files with 264 additions and 230 deletions.
diff --git a/packages/checkout/sdk/src/Checkout.test.ts b/packages/checkout/sdk/src/Checkout.test.ts
@@ -101,7 +101,6 @@ describe('Connect', () => {
  });
 
  expect(connectSite).toBeCalledTimes(1);
- expect(getNetworkInfo).toBeCalledTimes(1);
  });
 
  it('should call getBalance when no contract address provided', async () => {

diff --git a/packages/checkout/sdk/src/Checkout.ts b/packages/checkout/sdk/src/Checkout.ts
@@ -134,13 +134,10 @@ export class Checkout {
  params.provider,
  { allowUnsupportedProvider: true } as ValidateProviderOptions,
  );
+
  await connect.connectSite(web3Provider);
- const networkInfo = await network.getNetworkInfo(this.config, web3Provider);
 
- return {
- provider: web3Provider,
- network: networkInfo,
- };
+ return { provider: web3Provider };
  }
 
  /**

diff --git a/packages/checkout/sdk/src/types/connect.ts b/packages/checkout/sdk/src/types/connect.ts
@@ -1,5 +1,4 @@
 import { Web3Provider } from '@ethersproject/providers';
-import { NetworkInfo } from './networkInfo';
 
 /**
  * Interface representing the params of {@link Checkout.connect}.
@@ -12,11 +11,9 @@ export interface ConnectParams {
 /**
  * Interface representing the result of {@link Checkout.connect}.
  * @property {Web3Provider} provider - The provider used to connect to the network.
- * @property {NetworkInfo} network - Information about the connected network.
  */
 export interface ConnectResult {
  provider: Web3Provider;
- network: NetworkInfo;
 }
 
 /**

diff --git a/packages/checkout/widgets-lib/src/components/ConnectLoader/ConnectLoader.cy.tsx b/packages/checkout/widgets-lib/src/components/ConnectLoader/ConnectLoader.cy.tsx
@@ -150,6 +150,7 @@ describe('ConnectLoader', () => {
  provider,
  getSigner: () => ({
  getAddress: async () => Promise.resolve(''),
+ getChainId: async () => Promise.resolve(ChainId.IMTBL_ZKEVM_TESTNET),
  }),
  isMetaMask: true,
  } as any as Web3Provider,

diff --git a/packages/checkout/widgets-lib/src/lib/analytics/identifyUser.ts b/packages/checkout/widgets-lib/src/lib/analytics/identifyUser.ts
@@ -14,8 +14,11 @@ export async function identifyUser(
  const walletAddress = (await provider.getSigner().getAddress()).toLowerCase();
  const isMetaMask = isMetaMaskProvider(provider);
  const isPassport = isPassportProvider(provider);
- identify(walletAddress, {
- isMetaMask,
- isPassportWallet: isPassport,
- });
+ try {
+ identify(walletAddress, {
+ isMetaMask,
+ isPassportWallet: isPassport,
+ });
+ // eslint-disable-next-line no-console
+ } catch (error: any) { console.error('analytics: unable to identify user: ', error); }
 }