Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transpile: fix curl transpile breakage while maintaining a total SrcLoc order #1163

Merged
merged 2 commits into from
Nov 18, 2024
Merged

transpile: fix curl transpile breakage while maintaining a total SrcLoc order #1163

merged 2 commits into from
Nov 18, 2024

Commits on Nov 18, 2024

  1. transpile: improve error message for SrcLoc total ordering test

    @kkysen
    kkysen committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a4a052b View commit details
    Browse the repository at this point in the history

  2. transpile: fix curl transpile breakage while maintaining a total `S… 

    …rcLoc` order

#1128 fixed the non-total (non-transitive) `SrcLoc` ordering,
but accidentally broke the `curl` transpilation test in `c2rust-testsuites`,
which is tested in CI, but was broken for external contributors PRs (fixed now in #1159).

In the `curl` transpilation, a couple of `use` imports (`__sigset_t` and `C2RustUnnamed_4`)
were missing, cause the build to fail afterward.

I'm still not exactly sure why this fixes the issue while maintaining a transitive, total order,
but it passes the total order test and transpiles `curl` correctly now.
Hopefully this is a complete fix, and I didn't just fix a one-off error in `curl`.
    @kkysen
    kkysen committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9679a3b View commit details
    Browse the repository at this point in the history