analyze: static/dynamic comparison mode for NON_NULL #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have my own changes for the PDG at #1158 and https://github.com/immunant/c2rust/tree/ahomescu/analyze-compare-static-dynamic-v2, we should probably de-duplicate our branches. Could you take a look at mine? |
After doing some rebasing, I see that your branch is the same as mine. Closing the latter. |
ahomescu
approved these changes
Nov 9, 2024
spernsteiner
force-pushed
the
analyze-compare-static-dynamic
branch
from
c9ee5e7
to
58d56c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mode for comparing static analysis results to the dynamic results from the PDG. Comparison mode is enabled by setting the env var
C2RUST_ANALYZE_COMPARE_PDG=1. When this mode is enabled, c2rust-analyze skips normal rewriting and instead prints a copy of the input code with annotation comments indicating places where static and dynamic NON_NULL results disagree. Specifically, it annotates cases where either the static analysis computed NON_NULL but the PDG includes at least one observation where the pointer is null, or the dynamic analysis marked the pointer nullable but the PDG contains observations that are all non-null.In support of the main change, this branch also includes a refactor of the PDG processing code.