Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Add subscription group name prefix for nodes #52

Closed
wants to merge 2 commits into from

Conversation

muink
Copy link
Collaborator

@muink muink commented Dec 1, 2023

No description provided.

@1715173329
Copy link
Member

1715173329 commented Dec 1, 2023

Absolutely no, please keep it simple and stupid.
If you want to make the node name more identifiable, just pad the label with domain name when parse subscriptions (e.g. take bar from foo.bar.com/whatever)

@muink
Copy link
Collaborator Author

muink commented Dec 2, 2023

But not all subscription URLs have human-readable SLD. For example, a provider's name is GoldFish, but its subscription URL's SLD is a string of meaningless characters such as sub.nutryuirelj.xyz. Such a node labels are not identifiable and beautiful.

@1715173329
Copy link
Member

So, if providers decide to use such a meaningless name, it's their own issue.

At least you should know exactly what subscription you entered, and that's enough.

@muink muink closed this Dec 2, 2023
@muink muink deleted the dev/prefix branch December 2, 2023 06:53
@1715173329 1715173329 mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants