Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): support for the HTTP-01 challenge #29

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

tgragnato
Copy link
Contributor

@tgragnato tgragnato commented Jan 5, 2024

closes #18

The functionality is designed to activate by setting "webroot" in the provider's configuration. It is the responsibility of system administrators to route HTTP traffic for the prefix /.well-known/acme-challenge/ to Inca.

TODO: There are no unit tests for the providers, and this is partially correct as we do not want to rewrite tests that cover the features provided by the library we are using (lego). However, it would be very helpful to start introducing tests for the glue code.

For now, the introduced functionality is trivial, and it seems possible to safely introduce it without implementing unit testing beforehand for this portion of the code.

NB: Static serving is heavily dependent on the WORKDIR /tmp Docker directive; everything breaks down in different environments.

@tgragnato tgragnato added the enhancement New feature or request label Jan 5, 2024
@tgragnato tgragnato self-assigned this Jan 5, 2024
Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a little bit of documentation on this feat?

@tgragnato
Copy link
Contributor Author

tgragnato commented Jan 5, 2024

Maybe we should add a little bit of documentation on this feat?

+1. A complete documentation is missing for basically everything regarding operations and the configuration yaml (not just this feature).

We could start documenting this and expand/recover a description of everything that's missing, starting from a basic skeleton.

What could be a good place for the docs?

@JellyBellyDev
Copy link
Member

+1. A complete documentation is missing for basically everything regarding operations and the configuration yaml (not just this feature).

We could start documenting this and expand/recover a description of everything that's missing, starting from a basic skeleton.

Ok no problem. I suggest to do this in new PR! ;)

What could be a good place for the docs?

One dir documentation at the root of repo with inside all file md and in the file readme the special toc for docs?

Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tgragnato
Copy link
Contributor Author

+1. A complete documentation is missing for basically everything regarding operations and the configuration yaml (not just this feature).
We could start documenting this and expand/recover a description of everything that's missing, starting from a basic skeleton.

Ok no problem. I suggest to do this in new PR! ;)

What could be a good place for the docs?

One dir documentation at the root of repo with inside all file md and in the file readme the special toc for docs?

#31

@tgragnato tgragnato merged commit f89dd6b into main Jan 8, 2024
3 checks passed
@tgragnato tgragnato deleted the feat/http01_challenge branch January 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP-01 challenge / Enhance the capabilities of the Let's Encrypt provider
2 participants