-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider): support for the HTTP-01 challenge #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add a little bit of documentation on this feat?
+1. A complete documentation is missing for basically everything regarding operations and the configuration yaml (not just this feature). We could start documenting this and expand/recover a description of everything that's missing, starting from a basic skeleton. What could be a good place for the docs? |
Ok no problem. I suggest to do this in new PR! ;)
One dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
closes #18
The functionality is designed to activate by setting "webroot" in the provider's configuration. It is the responsibility of system administrators to route HTTP traffic for the prefix
/.well-known/acme-challenge/
to Inca.TODO: There are no unit tests for the providers, and this is partially correct as we do not want to rewrite tests that cover the features provided by the library we are using (lego). However, it would be very helpful to start introducing tests for the glue code.
For now, the introduced functionality is trivial, and it seems possible to safely introduce it without implementing unit testing beforehand for this portion of the code.
NB: Static serving is heavily dependent on the
WORKDIR /tmp
Docker directive; everything breaks down in different environments.