Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): trust user-added CAs #14403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Nov 29, 2024

  1. feat(mobile): trust user-added CAs

    This PR allows the Android app to trust user-added CAs without skipping SSL
    certificate verification.
    
    It is pretty common that a self-hosted Immich server uses an SSL
    certificate issued by a self-signed CA, such as a company's
    internal CA.
    
    On Android systems, users can install a custom CA certificate
    by going to system Settings -> Security & privacy -> More Security and
    privacy -> Encryption & credentials -> Install a certificate.
    However, starting with Android N, an app doesn't trust user-added CAs by default
    unless it explicitly opts in. See
    https://developer.android.com/privacy-and-security/security-config for
    more information.
    
    iOS doesn't have this issue because it always trust user-added CAs.
    Even Chrome on Android trusts user-added CAs (https://github.com/chromium/chromium/blob/f65f60551faa7e21c176c951cf874ce98278fd0b/chrome/android/java/res_base/xml/network_security_config.xml#L8) so it shouldn't
    a security concern.
    vfreex committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    8df62b6 View commit details
    Browse the repository at this point in the history