Vectorizer and design essentials plugins #9
Conversation
…ch that one can have also utils or non-plugin packages
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Looking forward to using this, especially the commands and the vectorizer!
I've only been able to skim over the 160 changed files due to the volume. I've added some comments.
I've successfully build and tried this branch locally.
Personally, I feel that plugin-replicate-io and some of the experimental stuff maybe should not be merged into main, instead maybe should be extracted into their own PR until they are ready for consumptions.
Maybe it would make sense to keep the main "clean" with only really consumable plugins since this is public but not sure.
Also, the build step has failed, would you mind looking into it?
| @@ -0,0 +1,40 @@ | |||
| # IMG.LY CE.SDK Plugin Vectorizer | |||
There was a problem hiding this comment.
What exactly is this plugin-core? This Readme does not seem correct
| Define feature flags | ||
|
|
||
| Feature Enabled | ||
| Feature Permissions | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This file seems like a mental note. Not sure I'd like this to be merged, could be an issue or extracted into another PR
| // TODO: Extend this with the builtin commands from other packages | ||
|
|
| // { | ||
| // // THIS DOES not belong here maybe | ||
| // ctx.logger?.trace("Defaulting canvas menu order") | ||
| // const canvasMenuEntries = [ | ||
| // PluginManifest.contributes.ui.button.id, | ||
| // ...ctx.ui?.unstable_getCanvasMenuOrder() ?? [] | ||
| // ] | ||
| // ctx.ui?.unstable_setCanvasMenuOrder(canvasMenuEntries); | ||
| // } | ||
| } | ||
|
|
||
| // maybe this should be just engine.event.onUpdate() |
| { | ||
| "name": "@imgly/plugin-replicate-io", | ||
| "version": "0.1.0", | ||
| "description": "Vectorizer plugin for the CE.SDK editor", |
I left remove-background for now untouched for now.
Added everything I did so far, including revamping some details about the plugin api, if you generally concur than I would merge it for now or create something so I can keep on working with that.
Let me know what you think