Better support for latex #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In latex, only the path of the picture is needed (the rest could be done by snippet, which is seperate)
|
I think you should implement a function per file type and then choose the correct implementation |
ferrine
requested changes
Nov 18, 2020
| execute "normal! a" . g:mdip_tmpname[1:] . "](" . relpath . ")" | ||
| call setpos('.', ipos) | ||
| execute "normal! vt]\<C-g>" | ||
| if &filetype == 'md' || &filetype == 'pandoc' |
There was a problem hiding this comment.
I'm concerned by this approach. Better to separate file type logic from the function
|
Perhaps my PR, #56, could be of interest? |
|
Can we close this PR? Or there is still something to resolve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In latex, only the path of the picture is needed (the rest could be done by snippet, which is separate)
For the original path (like
), I put it under the markdown and pandoc filetype.