-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Umami analytics #328
Conversation
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi, thank you for the PR. I don't plan to include this in the next release, but will kep this open for the future. |
@imfing Any changes you’d like to see to this PR? Any chance this could be included in the next release? I’ve already tested the code and it works, would be great if I could remove my fork with the next release. |
This requires using a fork of the theme, since imfing/hextra#328 isn't merged yet.
This requires using a fork of the theme, since imfing/hextra#328 isn't merged yet.
Just a side note: for current versions ( <script async defer src="https://url" data-website-id="id" ></script> |
@@ -36,6 +36,11 @@ | |||
{{ partial "google-analytics.html" . }} | |||
{{- end }} | |||
|
|||
<!-- Umami --> | |||
{{- if and hugo.IsProduction .Site.Params.umami.serverURL .Site.Params.umami.id }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest placing it under analytics
:
params:
analytics:
# https://github.com/umami-software/umami
umami:
server: https://server-url
# script: umami.js
id: "site-id"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per above, also could you create another PR to add documentation for this?
Fixes #327.