add support for Umami analytics #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi, thank you for the PR. I don't plan to include this in the next release, but will kep this open for the future. |
|
@imfing Any changes you’d like to see to this PR? Any chance this could be included in the next release? I’ve already tested the code and it works, would be great if I could remove my fork with the next release. |
marten-seemann
added a commit
to quic-go/docs
that referenced
this pull request
Mar 27, 2024
This requires using a fork of the theme, since imfing/hextra#328 isn't merged yet.
marten-seemann
added a commit
to quic-go/docs
that referenced
this pull request
Mar 27, 2024
This requires using a fork of the theme, since imfing/hextra#328 isn't merged yet.
|
Just a side note: for current versions ( <script async defer src="https://url" data-website-id="id" ></script> |
imfing
reviewed
Mar 28, 2024
| @@ -36,6 +36,11 @@ | |||
| {{ partial "google-analytics.html" . }} | |||
| {{- end }} | |||
|
|
|||
| <!-- Umami --> | |||
| {{- if and hugo.IsProduction .Site.Params.umami.serverURL .Site.Params.umami.id }} | |||
There was a problem hiding this comment.
I suggest placing it under analytics:
params:
analytics:
# https://github.com/umami-software/umami
umami:
server: https://server-url
# script: umami.js
id: "site-id"
imfing
requested changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327.