Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix otel.trace: record exception in with_span #72

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix otel.trace: record exception in with_span #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/trace/opentelemetry_trace.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,19 @@ module Internal = struct
in

Otel.Scope.with_ambient_scope sb.scope @@ fun () ->
let rv = cb otrace_id in
match cb otrace_id with
| res ->
let otel_span = exit_span' otrace_id sb in
Otel.Trace.emit [ otel_span ];
res
| exception e ->
let bt = Printexc.get_raw_backtrace () in

Otel.Scope.record_exception sb.scope e bt;
let otel_span = exit_span' otrace_id sb in
Otel.Trace.emit [ otel_span ];

let otel_span = exit_span' otrace_id sb in
Otel.Trace.emit [ otel_span ];
rv
Printexc.raise_with_backtrace e bt

let enter_span ~__FUNCTION__ ~__FILE__ ~__LINE__ ~data name :
Trace_core.span =
Expand Down
Loading