Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add links to scope #66

Merged
merged 2 commits into from
Oct 7, 2024
Merged

add links to scope #66

merged 2 commits into from
Oct 7, 2024

Conversation

tatchi
Copy link
Contributor

@tatchi tatchi commented Oct 4, 2024 •
edited
Loading

As discussed, I'll try to implement the structure change in a subsequent PR

c-cube
c-cube approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@c-cube c-cube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very useful. I think we could also introduce Scope.make and use it in otel_cohttp_lwt but it doens't have to be done right now.

src/core/opentelemetry.ml Outdated Show resolved Hide resolved
src/core/opentelemetry.ml Show resolved Hide resolved
@tatchi
Copy link
Contributor Author

tatchi commented Oct 7, 2024 •
edited
Loading

I think we could also introduce Scope.make and use it in otel_cohttp_lwt

Added in 41f1f43 (#66)

@c-cube c-cube merged commit 036c108 into imandra-ai:main Oct 7, 2024
3 checks passed
@c-cube
Copy link
Member

c-cube commented Oct 7, 2024

Thank you, very nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-cube c-cube c-cube approved these changes

@mattjbray mattjbray Awaiting requested review from mattjbray mattjbray is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatchi @c-cube