add support for per-signal urls #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatchi
commented
Aug 2, 2024
tatchi
commented
Aug 2, 2024
tatchi
commented
Aug 2, 2024
Comment on lines
-6
to
-10
| val get_url : unit -> string | ||
|
|
||
| val set_url : string -> unit | ||
| (** Url of the endpoint. Default is "http://localhost:4318", | ||
| or "OTEL_EXPORTER_OTLP_ENDPOINT" if set. *) |
There was a problem hiding this comment.
Do we want to be able to change urls after setup? If so, I can re-introduce set_url_{traces,metrics,logs}.
For getters, I'm wondering if that's needed, one can always do:
let config = ref (Config.make ())
(* and then somewhere else *)
let url_traces = !config.url_tracesOr am I missing something ?
There was a problem hiding this comment.
I think we should be able to live without it. I'll double check but we normally use with_setup only which should be safe.
c-cube
approved these changes
Aug 2, 2024
Comment on lines
-6
to
-10
| val get_url : unit -> string | ||
|
|
||
| val set_url : string -> unit | ||
| (** Url of the endpoint. Default is "http://localhost:4318", | ||
| or "OTEL_EXPORTER_OTLP_ENDPOINT" if set. *) |
There was a problem hiding this comment.
I think we should be able to live without it. I'll double check but we normally use with_setup only which should be safe.
Co-authored-by: Simon Cruanes <[email protected]>
|
Thanks for the review, I've applied the same changes to the |
tatchi
commented
Aug 5, 2024
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for per-signal URLs configuration. See https://opentelemetry.io/docs/specs/otel/protocol/exporter/#endpoint-urls-for-otlphttp
I've only modified the
ocurlclient for now to reduce diff. Once approved, I can make the same changes for thelwtclient