perf and features #49

c-cube · 2023-12-20T21:14:19Z

this introduces:

self-tracing for the ocurl backend
GC metrics are collected on tick, not on GC signal (more regular)
new config options for ocurl backend (self tracing, and tick interval)

it's cleaner to emit GC events on ticks rather than on GC, because it avoids both spamming if the GC is very active, and emitting nothing when there are few allocations.

we don't go through OTEL for self tracing as it can create regular span emission where normally there would be none (emitting a self-tracing span might create a batch, which then has to be sent after the batch timeout, and sending that one creates a new span, etc.)

ticker interval will affect how often metrics are emitted, this doesn't need be related to batch timeouts.

it's less dangerous to emit spans for self-tracing, even if nothing else is going on, than risk having them accumulate in case the program emits no spans but emits a lot of metrics and logs (which create self-tracing spans)

src/client-ocurl/config.mli

c-cube added 10 commits December 20, 2023 14:01

perf: when we get multiple messages, check batches only once

5005c3a

otel-ocurl: some self-tracing

f0750cd

refine seld tracing

3d16de6

move AList to core

2ac799f

feat: use AList for tick callbacks; emit GC events on tick

bd8b483

it's cleaner to emit GC events on ticks rather than on GC, because it avoids both spamming if the GC is very active, and emitting nothing when there are few allocations.

ocurl: add ticker_interval_ms config

f031053

ticker interval will affect how often metrics are emitted, this doesn't need be related to batch timeouts.

detail

9c2b885

revert: use collector again for self-tracing spans

133b6ad

it's less dangerous to emit spans for self-tracing, even if nothing else is going on, than risk having them accumulate in case the program emits no spans but emits a lot of metrics and logs (which create self-tracing spans)

config: self-trace is disabled by default for now

b830c3d

c-cube requested a review from mattjbray as a code owner December 20, 2023 21:14

mattjbray approved these changes Dec 21, 2023

View reviewed changes

src/client-ocurl/config.mli Show resolved Hide resolved

more doc

031b7bf

c-cube merged commit b95eb21 into main Dec 21, 2023
3 checks passed

c-cube deleted the wip-perf-2023-12-20 branch December 21, 2023 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf and features #49

perf and features #49

c-cube commented Dec 20, 2023

perf and features #49

perf and features #49

Conversation

c-cube commented Dec 20, 2023