Add debug-wrapping backend #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I didn't come around to reviewing that earlier! I think it can be useful. @ELLIOTTCABLE would you rebase it? |
ELLIOTTCABLE
force-pushed
the
debugging-backend
branch
from
423efe7 to
fa265c6
Compare
* upstream/master: (40 commits) chore: add upper bound on pbrt fix: regenerate code with a non-pinned ocaml-protoc debug git diff chore: use protoc 2.4 in CI format ocamlformat add missing proto directory refactor tests to avoid circular dependencies no open move protobuf code to opentelemetry.proto trace-collector: Use Trace_core instead of Trace for OCaml v5 tests: Add every test-dep to every package chore: Prepare for v0.6 chore: Add myself to maintainers chore: update CHANGES dune fmt trace-collector: Pass user-data to OTel metrics deps: Update ocaml-trace dep to 0.4 trace-collector: Support for floats, etc from trace (- fix) Use new TLS-module naming from ac.0.1.0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was initially creating this as a utility for a test-harness; but realized it's a bit of a cleaner approach to debugging that's external to any particular collector.
For the moment, I've left the existing
debugmachinery in both the clients; but some of it may be redundant now?Additionally, this adds a "noop" collector, which when used with the
Debug_collectorfunctor, results in an implementation that just prints to stdout.