Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringToResultsTableConverter #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

imagejan
Copy link
Member

@imagejan imagejan commented Jun 17, 2021

This converter allows to get a ResultsTable by its title string. In addition, the populateInputCandidates() method allows to get a list of open results tables, e.g. to generate a choice dropdown in ObjectWidget.

Since we're using ImageJ1 classes directly, we need to add the new converter class to the exceptions in ImageJ1EncapsulationTest.

See also this forum discussion.

To be discussed:

  • It would be nice to extend the functionality to also allow loading ResultsTables from files, using the static ResultsTable.open(String path) method (possibly delegating to a new FileToResultsTableConverter). I'll leave this to a future pull request.

  • The current implementation of ObjectWidget and ObjectService#getName() returns the ResultsTable's toString() value, resulting in a rather cryptic identifier in the dropdown choice:

    #@ ResultsTable (autoFill = false) rt
    

    image

    We could create a custom widget for ResultsTable, but I'd prefer using ObjectWidget to keep everything concise (and staying with a converter has the added benefit that #@ parameters are callable from CLI/macros right away). Maybe we can improve ObjectService somehow to be extensible via a (new) NameProvider plugin mechanism, but I'm not sure if this would be overdoing it? @ctrueden do you have some opinion/advice here?

  • Tests for the new converter are currently missing.

This converter allows to get a ResultsTable by its title string.

In addition, the populateInputCandidates() method allows to get a list of open results tables, e.g. to generate a choice dropdown in ObjectWidget.

Since we're using ImageJ1 classes directly, we need to add the new converter class to the exceptions in ImageJ1EncapsulationTest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant