Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open extra file types with SCIFIO enabled #253

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Open extra file types with SCIFIO enabled #253

wants to merge 3 commits into from

Commits on Sep 30, 2020

  1. Formatting

    @hinerm
    hinerm committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    3eb0c3e View commit details
    Browse the repository at this point in the history

  2. Extract service initialization method 

    In hopes of making it a little clearer how these are being injected.
    @hinerm
    hinerm committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    34de750 View commit details
    Browse the repository at this point in the history

  3. Use UIService to display non-Datasets 

    This is necessary so that, when SCIFIO is enabled, non-dataset files
(e.g. CSV's) have a chance to be opened.
    @hinerm
    hinerm committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    66382af View commit details
    Browse the repository at this point in the history