Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo deny warnings and errors #2332

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix cargo deny warnings and errors #2332

merged 1 commit into from
Sep 23, 2024

Conversation

JamyGolden
Copy link
Contributor

The CI has been failing since 20 August 2024. Since it's been failing, I suspect commits following that PR have added things that have broken the cargo deny check command even more. This PR should make the CI green again.

This PR fixes the errors. Things this PR addresses:

  • Add targets property under [graph] field
  • Remove vulnerability and unmaintained properties since they've been removed from cargo-deny and now emit errors.
  • Remove unnecessary deny.toml properties like skip-tree. Maybe this was needed at some point, but it's not anymore.
  • Remove num-derive from skip list since it doesn't emit errors anymore.
  • Add miniz_oxide to skip list since some deps depend on 0.7.4 while others on 0.8.0. I've created a ex-rs PR on to bump the dep to 0.8.0 Update Cargo.toml dependencies and release 1.73.0 johannesvollmer/exrs#240

Current error/warning logs

The PR solves these erorr/warnings:

❯ cargo deny check
warning[deprecated]: this key will be removed in a future update, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for details
   ┌─ /home/user/projects/image/deny.toml:14:1
   │
14 │ vulnerability = "deny"
   │ ^^^^^^^^^^^^^

warning[deprecated]: this key will be removed in a future update, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for details
   ┌─ /home/user/projects/image/deny.toml:15:1
   │
15 │ unmaintained = "warn"
   │ ^^^^^^^^^^^^

warning[deprecated]: this key will be removed in a future update, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for details
   ┌─ /home/user/projects/image/deny.toml:36:1
   │
36 │ unlicensed = "allow"
   │ ^^^^^^^^^^

warning[deprecated]: this key will be removed in a future update, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for details
   ┌─ /home/suer/projects/image/deny.toml:37:1
   │
37 │ allow-osi-fsf-free = "either"
   │ ^^^^^^^^^^^^^^^^^^

warning[deprecated]: this key will be removed in a future update, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for details
   ┌─ /home/user/projects/image/deny.toml:38:1
   │
38 │ copyleft = "allow"
   │ ^^^^^^^^

warning[deprecated]: this key has been moved to [graph]
  ┌─ /home/user/projects/image/deny.toml:3:1
  │
3 │ targets = [
  │ ^^^^^^^

warning[unmatched-skip-root]: skip tree root was not found in the dependency graph
   ┌─ /home/user/projects/image/deny.toml:30:15
   │
30 │     { name = "dav1d" }, # TODO: needs upgrade
   │               ^^^^^ no crate matched these criteria

error[duplicate]: found 2 duplicate entries for crate 'miniz_oxide'
   ┌─ /home/user/projects/image/Cargo.lock:61:1
   │
61 │ ╭ miniz_oxide 0.7.4 registry+https://github.com/rust-lang/crates.io-index
62 │ │ miniz_oxide 0.8.0 registry+https://github.com/rust-lang/crates.io-index
   │ ╰───────────────────────────────────────────────────────────────────────^ lock entries
   │
   = miniz_oxide v0.7.4
     ├── exr v1.72.0
     │   └── image v0.25.2
     └── png v0.17.13
         └── image v0.25.2 (*)
   = miniz_oxide v0.8.0
     └── flate2 v1.0.33
         ├── png v0.17.13
         │   └── image v0.25.2
         └── tiff v0.9.1
             └── image v0.25.2 (*)

advisories ok, bans FAILED, licenses ok, sources ok

@fintelia fintelia merged commit 9489d71 into image-rs:main Sep 23, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants