Breaking change. New parsing .env files logic #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
ReadConfig
only parses files, and doesn't load env variables.ReadConfig
with.env
file doesn't change os envs.ReadEnv
updates fields, read earlier fromReadConfig
Why
As stated in Contributing.md,
But, right now the behavior of
ReadConfig
is not obvious at all. And, in case with.env
- it's "magical". When I see two methodsReadEnv
andReadConfig
, I expect thatReadEnv
reads config only from envs, not from files; andReadConfig
only reads from a file, not from env variables. And If I need to do both, I should call both methods. But if I callReadConfig
with.env
file, I can't read env variables anymore, because they are changed.I suggest changing this behavior: make
ReadConfig
read only from the file, not from the env; and make it work correctly with.env
files (not to change os.GetEnv behavior).