Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Robot.java #3179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Basmalamoustafa
Copy link

#606 Robot pattern issue

Pull Request Template

What does this PR do?

iluwatar#606 Robot pattern issue
Copy link

github-actions bot commented Jan 14, 2025

PR Summary

Added TemplateViewRobot.java to facilitate testing of the TemplateView class. The class uses a ByteArrayOutputStream to capture the output of the render method and provides assertions to verify the rendered content.

Changes

File Summary
templateview/src/main/java/com/iluwatar/templateview/TemplateViewRobot.java This file defines the TemplateViewRobot class, which is used for testing the TemplateView class. It captures the output of the render method using a ByteArrayOutputStream and provides methods to verify the rendered content and reset the output stream.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)

#606 Robot pattern issue

Files Processed (1)
  • templateview/src/main/java/com/iluwatar/templateview/Robot.java (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
  • templateview/src/main/java/com/iluwatar/templateview/Robot.java [7-32]

    maintainability: "Inconsistent class and file names."

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • b5923df: Rename Robot.java to TemplateViewRobot.java
Files Processed (1)
  • templateview/src/main/java/com/iluwatar/templateview/TemplateViewRobot.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)

@iluwatar
Copy link
Owner

New patterns should follow the guidelines described here: https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants