Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of page_limit to pagination_request #28

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

annaglyph
Copy link

Description of this PR:
Update use of page_limit to pagination_request in engine.py

Scope:
Bug fix


'track_list()' was returning the error:
{'command_error_message': 'pagination_request', 'is_warning': False, 'command_error_type': 'PT_UnknownError'}

This was caused by 'page_limit' being deprecated since Pro Tools 2023::9

I've updated engine.py to use 'pagination_request' instead for get_file_location & track_list.

@StephenMachete
Copy link
Contributor

Great, thanks!

@iluvcapra
Copy link
Owner

@StephenMachete if you want to merge this into your PR that might make the most sense.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (3a2fa8d) to head (d8217ae).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          86       86           
  Lines        1455     1455           
=======================================
  Hits         1285     1285           
  Misses        170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iluvcapra
Copy link
Owner

This has been addressed in another merge but just addressed it permanently here. Thank you!

@iluvcapra iluvcapra merged commit 21b829a into iluvcapra:master Apr 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants