-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for new commands added in 2023.9 #24
Conversation
select_tracks_by_name() set_timeline_selection() get_timeline_selection()
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 89.48% 89.56% +0.07%
==========================================
Files 80 86 +6
Lines 1398 1437 +39
==========================================
+ Hits 1251 1287 +36
- Misses 147 150 +3 ☔ View full report in Codecov by Sentry. |
I've switched on the CI tests for this branch. Take a look at your changes and make sure everything is passing flake8 and then I'll review everything. The new engine methods are looking good though! |
Regarding these:
For now all I've been doing is keeping track of which releases work for which version of Pro Tools and if someone needs support for an older version, they can pin the older version of py-ptsl in their environment. Unfortunately each PTSL version is introducing breaking changes and Avid isn't changing the PTSLVersion, and they don't provide a method for interrogating the Pro Tools version itself so it's very challenging to provide support for a range of versions.
My feeling is, for now, on the Engine class it should just be ignored, make the limit extremely high and just let the response be huge, for 99% of cases that will work. If someone needed pagination, there should be separate methods on the Engine class to provide paginating methods, and these should return cursor objects that are Iterables. |
Hey just checking in on this, I might have a little time this week if you'd like some help! |
Description of this PR:
Initial work for support of new commands added in Pro Tools 2023.9.
Scope:
PTSL Coverage
I started work on this assuming it would just be a matter of calling
build_proto.sh
, but noticed there is quite a lot of manual steps - so I just started the work of adding the new functions for now.The changes are largely untested for now, I'm sending this PR at this stage to get feedback wether I'm missing something about the process.
The steps I took are outlined in the commit messages.
open questions about some upstream changes: