Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.md: Update OI environment file recommendations #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bill-Sommerfeld
Copy link
Contributor

More updates for openindiana.

@mtelka
Copy link
Contributor

mtelka commented Nov 3, 2024

For Perl I prefer this: #91

Copy link
Contributor

@mtelka mtelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ON_CLOSED_BINS line is not needed too, because there is no consumer for it.

@mtelka
Copy link
Contributor

mtelka commented Nov 3, 2024

The ON_CLOSED_BINS line is not needed too, because there is no consumer for it.

Obviously, there is consumer for it. The reason the line is not needed because it is already in illumos.sh.

@Bill-Sommerfeld
Copy link
Contributor Author

For Perl I prefer this: #91

Done

The ON_CLOSED_BINS line is not needed too, because there is no consumer for it.

Obviously, there is consumer for it. The reason the line is not needed because it is already in illumos.sh.

Done.

@mtelka
Copy link
Contributor

mtelka commented Nov 3, 2024

For Perl I prefer this: #91

Done

Wouldn't it be simpler to somehow manage the #91 merged instead?

The ON_CLOSED_BINS line is not needed too, because there is no consumer for it.

Obviously, there is consumer for it. The reason the line is not needed because it is already in illumos.sh.

Done.

Thanks.

@Bill-Sommerfeld
Copy link
Contributor Author

Wouldn't it be simpler to somehow manage the #91 merged instead?

This has adjacent deletions so just absorbing #91 into this one has less risk of merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants