illumos/dev-guide#40 Update for gerrit, illumos-docs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illumos/dev-guid#49 Update glossary page about lint Portions contributed by: Richard Lowe <[email protected]>
richlowe
reviewed
Aug 9, 2023
anatomy
Outdated
| `OBJS` and `SRCS`. We use both throughout the build and to help drive things | ||
| like `lint`. In `OBJS` we place a list of our object files. In this case we only | ||
| `OBJS`. We use both throughout the build and to help drive | ||
| otehr targets. In `OBJS` we place a list of our object files. In this case we only |
There was a problem hiding this comment.
Addressed, thanks.
anatomy
Outdated
| before. Finally, we end things with an include of `Makefile.targ` from inside of | ||
| From here on out, things stay relatively straightforward. Previously we | ||
| didn't worry about a `clean` target, but now that we've generated | ||
| intermeidate object files we have to go through and clean them up. |
There was a problem hiding this comment.
Addressed, thanks.
anatomy
Outdated
| variable. The second is to change how we're handling the `lint` target. | ||
| Currently the `lint` target is set to `lint_PROG`. We need to change that to | ||
| `lint_SRCS`. While the `SRCS` assignment we made in `Makefile.com` earlier may | ||
| variable. to While the `SRCS` assignment we made in `Makefile.com` earlier may |
There was a problem hiding this comment.
Weirdness here, not sure what happened
There was a problem hiding this comment.
Leftovers from attempting to deal with SRCS which is no longer really required I think.
pfmooney
reviewed
Aug 9, 2023
integrating
Outdated
| return when you have corrected those issues. The advocates is made up of members | ||
| of the community and while they have commit access to the gate, they are also | ||
| required to go through the same process. | ||
| RTI is sent to the the core team. n core team member who is familiar with the |
integrating
Outdated
| RTI is sent to the the core team. n core team member who is familiar with the | ||
| subject matter will review the materials and either accept it or not. If the | ||
| change isn't accepted for whatever reason, then the core team member will | ||
| explain why and work with to get things integrated. Most of the time, the core |
There was a problem hiding this comment.
Hopefully this is better.
integrating
Outdated
Comment on lines
19
to
20
| or confirmation about a change. The core team members go through this same | ||
| process. |
There was a problem hiding this comment.
perhaps amend to say "go through this same process when integrating their own changes"?
integrating
Outdated
|
|
||
| * List of Reviewers | ||
|
|
||
| * Explanation of Testing | ||
| * Explanation of Testing in the ticket |
There was a problem hiding this comment.
Probably because when I did this almost a decade ago I was trying to think of it like a section title ala reviewers above. Cleaned up.
integrating
Outdated
| things between you and your reviewers, that is something that you need to tell | ||
| the advocates. | ||
| things between you and your reviewers, that is something that you should | ||
| mention in the core team. It's okay to still submit the change. |
There was a problem hiding this comment.
Should have been "mention to". Fixed.
integrating
Outdated
| Like the rest of us, members of the core team are human, and occasionally a | ||
| given change might fall through the cracks. It could be that the core team | ||
| member most familiar with your area is not available and someone is waiting for | ||
| them tog et back. If a core team member needs time to review the contents of |
rmustacc
commented
Aug 10, 2023
anatomy
Outdated
| variable. The second is to change how we're handling the `lint` target. | ||
| Currently the `lint` target is set to `lint_PROG`. We need to change that to | ||
| `lint_SRCS`. While the `SRCS` assignment we made in `Makefile.com` earlier may | ||
| variable. to While the `SRCS` assignment we made in `Makefile.com` earlier may |
There was a problem hiding this comment.
Leftovers from attempting to deal with SRCS which is no longer really required I think.
anatomy
Outdated
| before. Finally, we end things with an include of `Makefile.targ` from inside of | ||
| From here on out, things stay relatively straightforward. Previously we | ||
| didn't worry about a `clean` target, but now that we've generated | ||
| intermeidate object files we have to go through and clean them up. |
There was a problem hiding this comment.
Addressed, thanks.
anatomy
Outdated
| `OBJS` and `SRCS`. We use both throughout the build and to help drive things | ||
| like `lint`. In `OBJS` we place a list of our object files. In this case we only | ||
| `OBJS`. We use both throughout the build and to help drive | ||
| otehr targets. In `OBJS` we place a list of our object files. In this case we only |
There was a problem hiding this comment.
Addressed, thanks.
integrating
Outdated
| return when you have corrected those issues. The advocates is made up of members | ||
| of the community and while they have commit access to the gate, they are also | ||
| required to go through the same process. | ||
| RTI is sent to the the core team. n core team member who is familiar with the |
integrating
Outdated
| RTI is sent to the the core team. n core team member who is familiar with the | ||
| subject matter will review the materials and either accept it or not. If the | ||
| change isn't accepted for whatever reason, then the core team member will | ||
| explain why and work with to get things integrated. Most of the time, the core |
There was a problem hiding this comment.
Hopefully this is better.
integrating
Outdated
Comment on lines
19
to
20
| or confirmation about a change. The core team members go through this same | ||
| process. |
integrating
Outdated
|
|
||
| * List of Reviewers | ||
|
|
||
| * Explanation of Testing | ||
| * Explanation of Testing in the ticket |
There was a problem hiding this comment.
Probably because when I did this almost a decade ago I was trying to think of it like a section title ala reviewers above. Cleaned up.
integrating
Outdated
| things between you and your reviewers, that is something that you need to tell | ||
| the advocates. | ||
| things between you and your reviewers, that is something that you should | ||
| mention in the core team. It's okay to still submit the change. |
There was a problem hiding this comment.
Should have been "mention to". Fixed.
integrating
Outdated
| Like the rest of us, members of the core team are human, and occasionally a | ||
| given change might fall through the cracks. It could be that the core team | ||
| member most familiar with your area is not available and someone is waiting for | ||
| them tog et back. If a core team member needs time to review the contents of |
richlowe
approved these changes
Aug 21, 2023
|
Thanks all. I've landed this manually in d8fb997 so I could keep the commit message correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overhauls a number of different sections that are out of date, like webrev, etc. It also incorporates parts of #38.