Skip to content

Commit

Permalink
Merge pull request #3265 from illacloud/merge/fix/builder-bug-wtf
Browse files Browse the repository at this point in the history
Merge/fix/builder bug wtf
  • Loading branch information
Wangtaofeng authored Oct 25, 2023
2 parents b53efee + f3f4682 commit c9a711f
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const sessionListContainerStyle = css`
width: 100%;
display: flex;
flex-direction: column;
padding-bottom: 40px;
`

export const sessionContainerStyle = css`
Expand Down
2 changes: 1 addition & 1 deletion apps/builder/src/widgetLibrary/MapBoxWidget/map.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const WrapperMap: FC<WrappedMapProps> = (props) => {
{
displayName,
value: {
markers: markers || DefaultMarkers,
markers: markers || [],
},
},
])
Expand Down
3 changes: 1 addition & 2 deletions apps/builder/src/widgetLibrary/MapBoxWidget/mapBox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { SearchInput } from "./SearchInput"
import {
ContainerStyle,
DefaultCenter,
DefaultMarkers,
DefaultZoom,
LatitudeFieldName,
Libraries,
Expand All @@ -24,7 +23,7 @@ export const MapBox: FC<MapProps> = ({
latitudeFieldName = LatitudeFieldName,
longitudeFieldName = LongitudeFieldName,
zoom = DefaultZoom,
markers = DefaultMarkers,
markers = "",
enableAddMark = true,
enableSearch = true,
enableClustering = false,
Expand Down
3 changes: 0 additions & 3 deletions apps/builder/src/widgetLibrary/RecordingWidget/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,3 @@ export const DefaultClearText = i18n.t(
export const RecordPermission = i18n.t(
"editor.inspect.setter_message.recording.recording_permission",
)
export const SetValueMessage = i18n.t(
"editor.inspect.setter_message.recording.cannot_set_value_dur",
)
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ export const RECORDING_HANDLER_CONFIG: EventHandlerConfig = {
value: "change",
},
],
methods: ["setValue", "clearValue", "validate", "clearValidation"],
methods: ["clearValue", "validate", "clearValidation"],
}
20 changes: 0 additions & 20 deletions apps/builder/src/widgetLibrary/RecordingWidget/recording.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { InvalidMessage } from "@/widgetLibrary/PublicSector/InvalidMessage"
import { handleValidateCheck } from "@/widgetLibrary/PublicSector/InvalidMessage/utils"
import { TooltipWrapper } from "@/widgetLibrary/PublicSector/TooltipWrapper"
import { BaseRecorder } from "@/widgetLibrary/RecordingWidget/baseRecord"
import { SetValueMessage } from "@/widgetLibrary/RecordingWidget/constants"
import {
AudioRecorderWidgetProps,
WrappedAudioRecorderProps,
Expand Down Expand Up @@ -131,25 +130,6 @@ export const RecordingWidget: FC<AudioRecorderWidgetProps> = (props) => {

useEffect(() => {
updateComponentRuntimeProps({
setValue: (value: unknown) => {
if (isRecording) {
messageModal.info({
content: SetValueMessage,
})
return
}
if (typeof value !== "string") {
return
}
handleUpdateMultiExecutionResult([
{
displayName,
value: {
value: value,
},
},
])
},
clearValue: () => {
handleUpdateMultiExecutionResult([
{
Expand Down

0 comments on commit c9a711f

Please sign in to comment.