chore: 优化sdk打包命令 #339
Merged
chore: 优化sdk打包命令 #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
贡献者你好
很高兴你能付出自己的时间参与到vue-fabric-editor的共享当中去，相信很多人都因为你提交的代码而收益。
原则
我们希望每次提交尽量小，较大重构除外，确保我们每次的改动影响范围清晰明了，能够方便项目维护者快速的将代码合并到主分支。
确保你的代码与主仓库没有冲突
在PR前，请确保你的代码与主仓库保持同步，可以参考这篇文章。
确保你的代码代码能正常打包构建
在PR前，请在本地进行打包构建，并进行功能测试，确保功能正常，且不影响其他功能。
告知项目维护者本次修改的功能
1：将package.json的npm改为pnpm, 使用了pnpm作为monorepo，就需要pnpm安装依赖，不然package/core依赖可能有问题
2：优化打包命令，将sdk打包的vite.config.ts移到对应项目， build:sdk时直接执行package/core的build命令