Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slim integration for multiarch builds in GitHub CI #36

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

lreiher
Copy link
Member

@lreiher lreiher commented Oct 28, 2024

  • Integrate docker-slim for waaaaaaaay smaller run images #33 has integrated built-in support for slim. A hotfix is required to run slim in GitHub jobs that build multiarch images, i.e., platforms: amd64,arm64 and enable-singlearch-push: false.
  • Currently, the lines responsible for pushing the slimmed image cannot handle multiarch-tags, see this mqtt_client action log.
  • The fix is to re-run slim in the second push execution of ci.sh, where platforms are not treated separately anymore. A current shortcoming is that slim is then only executed for the native platform, i.e., amd64 in most cases. You would end up with latest (multiarch) and latest-slim (singlearch).
  • A successful mqtt_client action log is found here.

@lreiher lreiher requested a review from jpbusch October 28, 2024 13:53
@lreiher lreiher merged commit 1ca378d into main Oct 28, 2024
6 checks passed
@lreiher lreiher deleted the fix/slim-github-ci branch October 28, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants