Downstreamed changes from @embroider/[email protected] #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
commented
Dec 20, 2023
Comment on lines
+19
to
+26
| [ | ||
| "module:decorator-transforms", | ||
| { | ||
| "runtime": { | ||
| "import": "decorator-transforms/runtime" | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
ijlee2
commented
Dec 20, 2023
| @@ -2,6 +2,7 @@ | |||
| // These will *not* be published as part of your addon, so be careful that your published code does not rely on them! | |||
| <% if (options.packages.addon.hasGlint) { %> | |||
| import '@glint/environment-ember-loose'; | |||
| // import '@glint/environment-ember-template-imports'; | |||
There was a problem hiding this comment.
embroider-build/addon-blueprint#218
At the moment, the codemod doesn't check if @glint/environment-ember-template-imports (optional) is installed. Rather than omitting the line, I opted to comment the line.
ijlee2
commented
Dec 20, 2023
| @@ -21,6 +21,7 @@ function setCompilerOptions( | |||
| compilerOptions.set('allowImportingTsExtensions', true); | |||
| compilerOptions.set('allowJs', true); | |||
| compilerOptions.set('declarationDir', 'declarations'); | |||
| compilerOptions.set('rootDir', './src'); | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
decorator-transformslatestVersionsI tested the changes on a couple of addons: