Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo structure #12

Closed
wants to merge 2 commits into from
Closed

Monorepo structure #12

wants to merge 2 commits into from

Conversation

karesztrk
Copy link
Collaborator

No description provided.

@karesztrk
Copy link
Collaborator Author

On my side the Zig build is failing with the following:

/home/ktorok/Projects/md4w/packages/core/build.zig:12:33: error: no field named 'path' in union 'Build.LazyPath'
        .root_source_file = .{ .path = "src/md4w.zig" },
                                ^~~~
/usr/lib/zig/std/Build.zig:2171:22: note: union declared here
pub const LazyPath = union(enum) {
                     ^~~~~
referenced by:
    build: /home/ktorok/Projects/md4w/packages/core/build.zig:4:14
    runBuild__anon_8819: /usr/lib/zig/std/Build.zig:2116:27
    remaining reference traces hidden; use '-freference-trace' to see all reference traces
/home/ktorok/Projects/md4w/packages/core/build.zig:12:33: error: no field named 'path' in union 'Build.LazyPath'
        .root_source_file = .{ .path = "src/md4w.zig" },
                                ^~~~
/usr/lib/zig/std/Build.zig:2171:22: note: union declared here
pub const LazyPath = union(enum) {
                     ^~~~~

@karesztrk karesztrk force-pushed the monorepo branch 3 times, most recently from db1fc1b to 93deb33 Compare July 25, 2024 14:12
@karesztrk
Copy link
Collaborator Author

You may want to extend the README, @ije

@karesztrk karesztrk force-pushed the monorepo branch 2 times, most recently from 7370632 to 153e45e Compare July 25, 2024 14:23
@karesztrk karesztrk requested a review from ije July 26, 2024 06:23
@ije
Copy link
Owner

ije commented Jul 26, 2024

On my side the Zig build is failing with the following:

please use zig 0.11, the wasm build output of zig 0.12+ is significantly increased. i still wonder what change happened, and i have a plan to rewrite it in pure zig.

@karesztrk karesztrk mentioned this pull request Jul 26, 2024
@karesztrk
Copy link
Collaborator Author

I see. If you have any other improvement ideas then let me know. By the way, I wished to name the webcomponent part like md4w/webcomponent but that's an invalid name. That would require a scope package. Do you have plans towards scoped packages?

@karesztrk
Copy link
Collaborator Author

@ije are you still considering the merge of our works into a monorepo? If not then we can close this.

@ije
Copy link
Owner

ije commented Aug 1, 2024

sorry for the late reply and thanks for your contribution, i feel this PR beyonds the simple goal of being a wasm module wihtout deps. why not keep the md4wc in your scope and put the link in this repo?

@karesztrk
Copy link
Collaborator Author

Sure, no problem

@karesztrk karesztrk closed this Aug 1, 2024
@karesztrk karesztrk deleted the monorepo branch August 1, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants