assertive deprecated from cran #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerpease
approved these changes
Feb 16, 2024
| @@ -61,7 +61,7 @@ agg_categorical <- function(dt, | |||
| "* See `missing_dt_severity` argument if it is okay to only make ", | |||
| "aggregate/scale data that are possible given what is available.\n", | |||
| paste0(capture.output(missing_dt), collapse = "\n")) | |||
| assertive::assert_engine(empty_missing_dt, missing_dt, | |||
| assertive.base::assert_engine(empty_missing_dt, missing_dt, | |||
There was a problem hiding this comment.
It looks like we need to come up with an alternative to signaling different severity levels before we can fully remove assertive.
There was a problem hiding this comment.
Yeah exactly. I got stuck on this but assertive.base seems to work for now.
| @@ -516,7 +516,7 @@ assert_agg_scale_args <- function(dt, | |||
|
|
|||
| } | |||
| } else { | |||
| assertthat::assert_that(assertive::is_null(mapping), | |||
| assertthat::assert_that(is.null(mapping), | |||
There was a problem hiding this comment.
For later: I don't think assertthat buys us anything over checkmate and we should also consider switching that over as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.