Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String contexts for several strings #5248

Open
2 of 7 tasks
zenseii opened this issue Apr 10, 2022 · 4 comments
Open
2 of 7 tasks

String contexts for several strings #5248

zenseii opened this issue Apr 10, 2022 · 4 comments
Labels
good first issue Good for newcomers improvement New feature, request or improvement translation Things related to languages and translations
Milestone

Comments

@zenseii
Copy link
Collaborator

zenseii commented Apr 10, 2022

Preliminary checks

Describe the problem requiring a solution

More contexts should be added for these strings both for improving the game and to accomodate for other languages:

  • Abbreviated and unabbreviated building names to be allowed to write things like Upgraded blacksmith where the space permits it. This would be very helpful for many languages that lack a proper translation for "upgraded":
    image

  • Arena primary skills. The German word Verteidigung is randomly broken mid-word
    image

  • Class in scenario information.
    This should be seen in relation to Allow using 2 lines for several headers for other languages #5244
    image

  • Speed in the combat options. Speed in this case is different from the speed attribute of creatures for several languages.
    (Polish is used to show where I'm talking about. Not sure if this is the case for Polish.)
    imageimage

  • Spell names in cases they should be contained within 2 lines and not. A solution of implementing
    line-breaking at hyphens - wouldn't be optimal because the hyphen should be removed if single-lined.
    imageimage

  • Secondary skill level placed on the bottom of the skill icon is definable for each skill in translations of the OG.
    This is needed for cases when the adjective changes gender like "Logistica Esperta" but "Orientamento Esperto".
    This avoids unnecessary use of /.
    image

Describe the possible solution

For the most part you would need to add the usual context prefix ex. combatOption|Speed. For Classes you'll need to create another enumeration since right now only the Necromancer class has its own context in a switch - another approach should probably be used to avoid having to switch through every class name.

Additional info

No response

@zenseii zenseii added the improvement New feature, request or improvement label Apr 10, 2022
@oleg-derevenetz oleg-derevenetz added the translation Things related to languages and translations label Apr 10, 2022
@oleg-derevenetz oleg-derevenetz added this to the 0.9.16 milestone Apr 10, 2022
@ihhub ihhub modified the milestones: 0.9.16, 0.9.17 Jun 12, 2022
@ihhub ihhub modified the milestones: 0.9.17, 0.9.18 Jul 11, 2022
@ihhub ihhub modified the milestones: 0.9.18, 0.9.19 Aug 10, 2022
@ihhub ihhub modified the milestones: 0.9.19, 0.9.20 Sep 11, 2022
@ihhub ihhub modified the milestones: 0.9.20, 0.9.21 Oct 10, 2022
@ihhub ihhub modified the milestones: 0.9.21, 1.0 Nov 12, 2022
@zenseii
Copy link
Collaborator Author

zenseii commented Dec 3, 2022

Related closed PR #5983

@ihhub ihhub modified the milestones: 1.0, 1.0.1 Dec 20, 2022
@ihhub ihhub modified the milestones: 1.0.1, 1.0.2 Feb 8, 2023
@ihhub ihhub modified the milestones: 1.0.2, 1.0.3 Mar 12, 2023
@ihhub ihhub modified the milestones: 1.0.3, 1.0.4 Apr 11, 2023
@ihhub ihhub modified the milestones: 1.0.4, 1.0.5 May 13, 2023
@ihhub ihhub modified the milestones: 1.0.5, 1.0.6 Jun 14, 2023
@ihhub ihhub modified the milestones: 1.0.6, 1.0.7 Jul 15, 2023
@ihhub ihhub modified the milestones: 1.0.7, 1.0.8 Aug 14, 2023
@zenseii zenseii added the good first issue Good for newcomers label Aug 20, 2023
@zenseii
Copy link
Collaborator Author

zenseii commented Aug 20, 2023

Many of these are still valid, and there are many more throughout the engine. Most of them should be easy fixes so I'm marking it as good first issue.

@ihhub ihhub modified the milestones: 1.0.8, 1.0.9 Sep 11, 2023
@ihhub ihhub modified the milestones: 1.0.9, 1.0.10 Oct 11, 2023
@ihhub ihhub modified the milestones: 1.0.10, 1.0.11 Nov 18, 2023
@ihhub ihhub modified the milestones: 1.0.11, 1.1.0 Dec 23, 2023
@ihhub ihhub modified the milestones: 1.1.0, 1.1.1 May 22, 2024
@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 13, 2024
@ihhub ihhub modified the milestones: 1.1.2, 1.1.3 Sep 15, 2024
@ihhub ihhub modified the milestones: 1.1.3, 1.1.4 Oct 23, 2024
@felix-schneider
Copy link
Contributor

felix-schneider commented Nov 7, 2024

Digging this up again. Similar to my thoughts on #9260, even though it would lead to many more strings, the descriptions of the buildings may need individual translation strings. In some languages, both the article of the building name and the grammatical form of the creature they produce may be different from the base form.

Edit: regarding 2 and 5:
The elegant way of solving this would be the use of a soft hyphen. That is probably not available in many of the encodings that the translations are in. What would it take to make all translation files use Unicode? Of course, the rendering code would need to support it as well.

@ihhub
Copy link
Owner

ihhub commented Nov 8, 2024

Hi @felix-schneider , using Unicode is not possible by 2 reasons:

  • the original game uses code pages (actually each copy of the game uses its own code page). This lead to a fact that now the whole texts depend on code pages. We don't have Unicode support in the code
  • we have no default font. Almost every single non-English letter is generated by the engine. Once Unicode is being added we have to solve the problem with fonts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Development

No branches or pull requests

4 participants