Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala 2.13.0 to 2.13.4 #141

Merged
merged 6 commits into from
Jun 22, 2021
Merged

Conversation

Philippus
Copy link

@Philippus Philippus commented Feb 14, 2021

Applying this PR will update scala 2.13.0 to 2.13.4. I had to make the bundle class extend scala.annotation.Annotation to make it compile under scala 2.13.1 and higher. Probably because of scala/scala#7546. Also fixed a warning and updated sbt-scoverage to make the build green again. Also added a test to show that the use case in issue #82 now works.

@coveralls
Copy link

coveralls commented Feb 14, 2021

Coverage Status

Coverage remained the same at 95.918% when pulling d7b9016 on Philippus:issue-82 into cc542fa on iheartradio:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 95.152% when pulling d7b9016 on Philippus:issue-82 into cc542fa on iheartradio:master.

@Philippus
Copy link
Author

ping @kailuowang

@kailuowang kailuowang merged commit e82a37a into iheartradio:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants