fix: bfs() no longer pads order with zeros with igraph_options(return.vs.es = FALSE)
#1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): Coverage |
|
@krlmlr this was great, but unfortunately we need the same change for |
jefferis
reviewed
Jan 29, 2024
| @@ -6,4 +6,7 @@ test_that("DFS uses 1-based root vertex index", { | |||
| test_that("DFS does not pad order", { | |||
| g <- make_star(3) | |||
| expect_equal(as.numeric(dfs(g, root = 2, unreachable = FALSE)$order), c(2, 1)) | |||
|
|
|||
| local_igraph_options(return.vs.es = FALSE) | |||
| expect_equal(as.numeric(bfs(g, root = 2, unreachable = FALSE)$order), c(2, 1)) | |||
There was a problem hiding this comment.
I guess this should have been
expect_equal(as.numeric(**dfs**(g, root = 2, unreachable = FALSE)$order), c(2, 1))
There was a problem hiding this comment.
Thanks, investigating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jefferis: For natverse/nat#517 (comment).