-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from libsignal-protocol-java to libsignal #565
base: master
Are you sure you want to change the base?
Conversation
smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoKeyUtil.java
Outdated
Show resolved
Hide resolved
smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoKeyUtil.java
Outdated
Show resolved
Hide resolved
@vanitasvitae we are in the process of release the next version of Smack and it seems like this PR would be a good candidate for the next version. Could I bribe you into rebasing this PR onto the latest master while addressing the sensible suggestions @stokito gave? Thanks in advance :) |
my comments are not important at all, just some styling. I'll remove them to not spent a time even on reading them |
I am sorry, but this is counter productive. The points you raised are valid and should be addressed before this is merged. For example, the new error prone version will flag the usages of Please restore your comments. |
8d657db
to
585a1e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
585a1e2
to
a8f16a1
Compare
Thanks for the late night work @vanitasvitae :)
if (!preKeyMessage.getPreKeyId().isPresent()) { Android added However, I am not yet sure why this check starts to fail now, in code that was not changed in this PR. Needs more investigation, but first lunch… ;) |
One further note: The PR still uses |
Please rebase, Smack's minimum Android SDK level is now 26. That should fix the compilation issue. |
a8f16a1
to
686295d
Compare
686295d
to
5e561f4
Compare
This PR moves away from
libsignal-protocol-java
which was archived in February of 2022 and instead makes use oflibsignal
which provides java bindings.The migration would require a minimum Android API level bump, since the
libsignal
code now usesjava.util.Optional
, which is Java 8 (and some Android API level higher than the current min).I have not done any interoperability- or integration testing yet.
It is also not yet clear, if the ecosystem (OMEMO next) will fork libsignal, or maintain a fork of libsignal-protocol-java instead, so consider this more a feasibility analysis for now :)