Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT/WIP: Serverless Messaging v2 (XEP-174) #25

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Flowdalic
Copy link
Member

No description provided.

Conflicts:
	smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java
@daveismith
Copy link

What's required to get this completed and integrated into the main branch?

@adrian-maggio
Copy link

Hello. My search for an XMPP library which supports XEP-174 brought me here. I see that this is the second PR, and that this issue is quite old in your JIRA (https://issues.igniterealtime.org/browse/SMACK-262?jql=text%20~%20%22smack-262%22).
I am assuming any code for this issue is probably out of date with respect to the current Smack baseline? Is there any work in-progress for this issue, or a plan to get it done?
Once I familiarize myself with Smack and development within it, I would be willing to take a look into what needs to happen to get it working.
At the very least, is there a path for me to get a build of Smack containing support for XEP-174, even if it is not merged to master?

@adrian-maggio
Copy link

Ok, I realized that I needed to clone Flowdalic's git repo (https://github.com/Flowdalic/Smack.git) in order to get the "serverless" branch.
However, there is a file name conflict, having to do with case, since I am on Windows, on the master branch:

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'smack-core/src/main/java/org/jivesoftware/smack/provider/IQProvider.java'
  'smack-core/src/main/java/org/jivesoftware/smack/provider/IqProvider.java'

Is Smack development on Windows not supported?

@adrian-maggio
Copy link

I had to clone the repo on a linux box, checkout the serverless branch, and then bring it back to Windows.
Running gradle clean build fails and complains about ANDROID_HOME not being set. Is an Android SDK being present a requirement to build Smack, even if I do not intend to target Android?

@adrian-maggio
Copy link

I installed Android Studio, including the API 8 SDK that the Smack build requested, but I still cannot build:

* Where:
Build file 'C:\devel\working\Flowdalic\Smack\smack-android\build.gradle' line: 19

* What went wrong:
A problem occurred evaluating project ':smack-android'.
> Could not set unknown property 'bootClasspath' for task ':smack-android:compileJava' property 'options' of type org.gradle.api.tasks.compile.CompileOptions.

After moving the two android projects temporarily out of the Smack directory, I get this error while building:

* Where:
Build file 'C:\devel\working\Flowdalic\Smack\smack-java7\build.gradle' line: 5

* What went wrong:
A problem occurred evaluating project ':smack-java7'.
> Plugin with id 'osgi' not found.

Can I get some help building Smack?
I am on Windows 10, with OpenJDK 11, using the Git Bash command line.

@adiaholic
Copy link
Contributor

adiaholic commented Jul 29, 2020

@adrian-maggio

Is Smack development on Windows not supported?

It is highly recommended to use Linux for development purposes.

@vanitasvitae
Copy link
Member

What version of gradle are you using? You should use gradle 6.2 or so.
As @adiaholic said, a linux environment is highly recommended for development :)

@Flowdalic
Copy link
Member Author

Support for Serverless Messaging (XEP-0174) would need to use SmackReactor those days. That would require some effort.

@adrian-maggio Please don't abuse PR comments for not-directly related discussion around the PR. Use the smack forum instead.

@igniterealtime igniterealtime locked as off-topic and limited conversation to collaborators Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants