Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer batch accumulator when rolling to new segment #1338

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

numinnex
Copy link
Contributor

No description provided.

@numinnex numinnex force-pushed the fix_accumulator_for_new_segment branch from bfd592e to a65f98d Compare November 13, 2024 19:32
@numinnex numinnex force-pushed the fix_accumulator_for_new_segment branch from a65f98d to b5d6821 Compare November 13, 2024 19:43
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11824637101

Details

  • 45 of 51 (88.24%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix_accumulator_for_new_segment at 75.127%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/src/channels/commands/maintain_messages.rs 0 1 0.0%
server/src/channels/commands/save_messages.rs 5 6 83.33%
server/src/compat/storage_conversion/persistency/partitions.rs 0 1 0.0%
server/src/streaming/partitions/messages.rs 2 5 40.0%
Totals Coverage Status
Change from base Build 11768736752: 75.1%
Covered Lines: 23128
Relevant Lines: 30785

💛 - Coveralls

@numinnex numinnex force-pushed the fix_accumulator_for_new_segment branch from 7f921b4 to 83d4346 Compare November 16, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants