Get CI running again #58
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grncdr
force-pushed
the
ci-tweaks
branch
2 times, most recently
from
33f5348 to
cda4ff5
Compare
|
I like where this is going 👍 |
Doing it this way ensures that generated YARD docs are present before the setup-ruby action updates it's cache.
These contained a load of duplicated definitions for methods that are inherited from Module. This will make tests a teensy tiny bit faster, but mostly makes these files actually sort of useful. These changes were made manually, the generate_definitions.rb script should probably be updated to be a bit more precise, but we can deal with that the next time somebody feels like running it.
If another test instantiates the Annotate class with a schema is present first, this test would fail. Singletons ...
|
This isn't green for me locally, based on 5d6fc92 I assume they are for you? It's the two devise tests that are complaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.