Support Ruby >= 3.1, Solargraph >= 0.48 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supporting old Solargraph versions is especially unhelpful.
|
A bit more context, I'm going to try and get #43 passing CI and collaborate with @iftheshoefritz to cut a new release, which will give us/me a better starting point for addressing various other open issues. |
alisnic
reviewed
May 11, 2023
Ah that's too bad! Thanks so much for your contributions, I feel like you really helped push the project forward. ❤️ |
iftheshoefritz
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been giving this project a bit of attention again recently, and my personal feeling is that the testing matrix is over-ambitious for so few contributors.
As noted in #55, CI is currently failing and it seems like nobody really knows why. IMO there's no reason to debug on a year old version of Solargraph.
I'd also like to put Rails versions in the test matrix, drop support for Rails 5 immediately, and maybe even Rails 6 too.
I personally am not working on any apps older than Rails 7 and CRuby 3.1, and I have zero reason to spend time making tests pass on older versions.