added tests for randomString and getPusher

[saminarp]

Description

I have written unit tests for the client/app/utils. The coverage report for the index.js has gone up to 65% with the corresponding tests I have written in index.test.js

More Details

While I was able to cover all the lines for the function randomString, the functions setCsrfToken, getPusher uses DOM implementation which makes it very tricky to mock it in Jest. Thus, they remain uncovered.

Corresponding Issue

#2128

Screenshots

---

Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!

[julianguyen]

Great work so far! Thanks for taking this on.

Looks like there's some ESLint failures in the CI build. You'll want to fix them. I recommend running yarn lint:eslint locally to reproduce the failures and verify when you've fixed them.

[julianguyen]

I think a better way to organize this is to structure the tests like so:

describe('Utils', () => {
  describe('randomString()`, () => {
    // etc.
  });
  
  describe('setCsrfToken()`, () => {
    // etc.
  });
  
  describe('getPusher()`, () => {
    // etc.
  });
  
   describe('renderContent()`, () => {
    // etc.
  });
});

[julianguyen]

I think you'll also want to test the return null case as well, when window.pusher does into exist.

[saminarp]

Hi @julianguyen I've done the changes, please review ☺️

[julianguyen]

Thanks for the updates, the tests looks good! 🎉

Just a few comments!

[julianguyen]

I don't think it's necessary to export these functions individually in order to be able to test them. You should be able to import the Utils object and call the functions as stated in the previous comment.

[julianguyen]

Let's use imports here instead, I recommend just pulling in the Utils object instead of adding new exports for each function.

Suggested change

	const { randomString, getPusher } = require('../index');
	import Utils from '../index';

Then you can call Utils.randomString() and Utils.getPusher().

[julianguyen]

Great work! Thanks for working on this 🎊

[welcome]

Thank you for merging this pull request with us! If you haven't already, in another pull request, please add yourself to our About page.