Feature/add time to medication alerts #1946
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First approach to add time support for medication alerts
More Details
I created the
db/migrate/20201229031222_add_time_to_medication_daily_reminders.rb
migration that adds a column for each day to add the time for daily reminders. Also, the frontend time inputs were added after the daily checkbox.The related issue is not completely solved yet but I would like to have a review on the approach.
I believe the next steps to close the issue are:
I would like to keep working on this, I'm not sure if I'll be able to finish it but, I'll keep you updated
Corresponding Issue
#1601.
Screenshots
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!