Skip to content

Commit

Permalink
Refactor ban method in ProfileController
Browse files Browse the repository at this point in the history
  • Loading branch information
@julianguyen
julianguyen committed Nov 6, 2018
1 parent 1a29459 commit 721df3c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 448 deletions.
293 changes: 0 additions & 293 deletions app/controllers/application_controller.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,297 +64,4 @@ def configure_for_accept_invitation
password_confirmation
invitation_token]
end
<<<<<<< HEAD
=======

helper_method :avatar_url, :viewer_of?,
:are_allies?, :get_uid, :most_focus,
:tag_usage, :can_notify, :if_not_signed_in,
:generate_comment, :get_stories, :moments_stats

def if_not_signed_in
return if user_signed_in?

respond_to do |format|
format.html { redirect_to new_user_session_path }
format.json { head :no_content }
end
end

def are_allies?(user_id1, user_id2)
users = User.where(id: [user_id1, user_id2])
users.first.mutual_allies?(users.last)
end

def viewer_of?(viewers)
viewers.include? current_user.id
end

def get_uid(user_id)
User.find(user_id).uid
end

# rubocop:disable MethodLength
# TODO: move this method out of the controller + refactor
def most_focus(data_type, profile_id)
data = []
user_id = profile_id || current_user.id
moments =
if current_user.id == profile_id
user_moments(user_id)
else
user_moments(user_id).where.not(published_at: nil)
end
if data_type == 'category'
strategies = user_strategies(user_id)
[moments, strategies].each do |records|
records.where(user_id: user_id).find_each do |r|
if r.category.any? && (profile_id.blank? ||
profile_exists?(profile_id, r))
data += r.category
end
end
end
elsif data_type.in?(%w[mood strategy])
moments.find_each do |m|
data_obj = m[data_type]
if data_obj.any? && (profile_id.blank? ||
profile_exists?(profile_id, m))
data += data_obj
end
end
end

data.empty? ? {} : top_three_focus(data)
end
# rubocop:enable MethodLength

# rubocop:disable MethodLength
def tag_usage(data_id, data_type, user_id)
result = []
moments = user_moments(user_id).order('created_at DESC')
if data_type == 'category'
strategies = user_strategies(user_id).order('created_at DESC')
[moments, strategies].each do |records|
objs = []
records.find_each do |r|
objs.push(r) if data_included?(data_type, data_id, r)
end
result << objs
end
elsif data_type.in?(%w[mood strategy])
moments.find_each do |m|
result << m if data_included?(data_type, data_id, m)
end
end
result
end
# rubocop:enable MethodLength

# rubocop:disable MethodLength
def get_stories(user, include_allies)
if user.id == current_user.id
my_moments = user.moments.all.recent
my_strategies = user.strategies.all.recent
end

if include_allies && user.id == current_user.id
allies = user.allies_by_status(:accepted)
allies.each do |ally|
my_moments += user_stories(ally, 'moments')
my_strategies += user_stories(ally, 'strategies')
end
elsif !include_allies && user.id != current_user.id
my_moments = user_stories(user, 'moments')
my_strategies = user_stories(user, 'strategies')
end

moments = Moment.where(id: my_moments.map(&:id)).order(created_at: :desc)
strategies = Strategy.where(id: my_strategies.map(&:id))
.order(created_at: :desc)

stories =
if moments.count.positive?
moments.zip(strategies).flatten.compact
else
strategies.compact
end

stories.sort_by(&:created_at).reverse!
end
# rubocop:enable MethodLength

# rubocop:disable MethodLength
# TODO: move this logic out of the controller and into a helper method
def moments_stats
total_count = current_user.moments.all.count
monthly_count = current_user.moments.where(
created_at: Time.current.beginning_of_month..Time.current
).count

return '' if total_count <= 1

result = '<div class="center stats">'
result += if total_count == 1
t('stats.total_moment', count: total_count.to_s)
else
t('stats.total_moments', count: total_count.to_s)
end

if total_count != monthly_count
result += ' '
result += if monthly_count == 1
t('stats.monthly_moment', count: monthly_count.to_s)
else
t('stats.monthly_moments', count: monthly_count.to_s)
end
end

result + '</div>'
end
# rubocop:enable MethodLength

private

def data_included?(data_type, data_id, data)
return false unless data_type.in?(%w[category mood strategy])

data_id.in?(data[data_type])
end

# TODO: refactor calling method to pass a hash to start with
def top_three_focus(data)
# Turn data array into hash of value => freq_of_value
freq = data.each_with_object(Hash.new(0)) do |value, hash|
hash[value] += 1
end

# Sort hash and take highest 3 values
freq.sort_by do |occurrences, _value|
occurrences
end[0..2].to_h
end

def profile_exists?(profile, data)
profile.present? &&
(current_user.id == profile ||
data.viewers.include?(current_user.id))
end

# rubocop:disable MethodLength
def user_created_data?(id, data_type)
case data_type
when 'moment'
Moment.where(id: id, user_id: current_user.id).exists?
when 'strategy'
Strategy.where(id: id, user_id: current_user.id).exists?
when 'meeting'
MeetingMember.where(meeting_id: id, leader: true,
user_id: current_user.id).exists?
else
false
end
end
# rubocop:enable MethodLength

def comment_deletable?(data, data_type)
data.comment_by == current_user.id ||
user_created_data?(data.commentable_id, data_type)
end

def comment_for(model_name)
@comment = Comment.create_from!(params)
@comment.notify_of_creation!(current_user)

respond_with_json(
generate_comment(@comment, model_name)
)
rescue ActiveRecord::RecordInvalid
respond_not_saved
end

def comment_reportable?(data)
data.comment_by != current_user.id
end

def show_with_comments(subject)
model_name = record_model_name(subject)

if current_user.id != subject.user_id && hide_page?(subject)
path = send("#{model_name.pluralize}_path")
return redirect_to_path(path)
end

set_show_with_comments_variables(subject, model_name)
end

# rubocop:disable MethodLength
def set_show_with_comments_variables(subject, model_name)
@page_author = if current_user.id != subject.user_id
User.find(subject.user_id)
else
User.find(current_user.id)
end
@no_hide_page = true
# rubocop:disable GuardClause
if subject.comment
@comment = Comment.new
@comments = Comment.where(
commentable_id: subject.id,
commentable_type: model_name
).order(created_at: :desc)
end
# rubocop:enable GuardClause
end
# rubocop:enable MethodLength

def record_model_name(record)
record.class.name.downcase
end

def redirect_to_path(path)
respond_to do |format|
format.html { redirect_to path }
format.json { head :no_content }
end
end

def respond_not_saved
respond_with_json(no_save: true)
end

def respond_with_json(reponse)
respond_to do |format|
format.html { render json: reponse }
format.json { render json: reponse }
end
end

def hide_page?(subject)
(!current_user.mutual_allies?(subject.user) \
&& !subject.viewer?(current_user)) \
|| !subject.published?
end

def user_strategies(user_id)
Strategy.where(user_id: user_id)
end

def user_moments(user_id)
Moment.where(user_id: user_id)
end

def user_stories(user, collection)
case collection
when 'moments'
query = Moment.published
when 'strategies'
query = Strategy.published
end

query.where(user_id: user.id).all.recent.map do |story|
story if story.viewers.include?(current_user.id)
end.compact
end
>>>>>>> e2ce9622... Report Feature added for Profile and Comments, Admin dashboard implemented
end
19 changes: 9 additions & 10 deletions app/controllers/profile_controller.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,20 @@ def remove_ban

private

def ban_mailer(user, banned)
return unless user.any?

def update_and_email(user, banned)
user.update(banned: banned)
if banned
BannedMailer.add_ban_email(user.first).deliver_now
BannedMailer.add_ban_email(user).deliver_now
else
BannedMailer.remove_ban_email(user.first).deliver_now
BannedMailer.remove_ban_email(user).deliver_now
end
end

def ban(banned)
return unless current_user.admin

user = User.where(id: params[:user_id]).update(banned: banned)
ban_mailer(user, banned)
user = User.find_by(id: params[:user_id])
update_and_email(user, banned) if user.present?
redirect_to(
admin_dashboard_path,
notice_or_alert(
Expand All @@ -47,9 +46,9 @@ def ban(banned)
end

def notice_or_alert(user, notice)
name = user&.first&.name || params[:user_id]
return { alert: t("reports.#{notice}_error", name: name) } unless user.any?
name = user&.name || params[:user_id]
return { notice: t("reports.#{notice}", name: name) } if user.present?

{ notice: t("reports.#{notice}", name: name) }
{ alert: t("reports.#{notice}_error", name: name) }
end
end
Loading

0 comments on commit 721df3c

Please sign in to comment.