Some fixes for php-repl.el #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* php-repl.el: Don't try to merge abbrev tables if `php-mode-abbrev-table' is unbound.
* php-repl.el (run-php): Move point to inferior php buffer. Otherwise major mode of current buffer is set to `inferior-php-mode'.
* php-repl.el: Fix missing quote.
* php-repl.el (run-php): Use `apply' to pass php repl program arguments. Otherwise if `php-repl-program-arguments' is the empty, the empty string is passed as argument for `php-repl-program' which causes the process to terminate.
…parens or curlies.
… token pairs instead of naive counters.
> If an unmatched token is incountered, in input, the read function will throw a generic exception.
> Semicolons are only implicitly added inside curlies, not inside parens.
…y still exit by typing Ctrl+X, 'die' or 'exit'
|
dmj's fixes really does fix the php repl on my Ubuntu, would love too see these merged. Thanks to the two of you! |
* php-repl.el (run-php-process-sentinel): New function. Process sentinel, restart PHP process after abnormal exit. (run-php): Use process sentinel.
* php-repl.el (run-php): Setq symbol before using it.
* php-repl.el (run-php): Don't change buffer and window when already visiting inferior-php-buffer.
* php-repl.el (php-repl): Fix typo in defgroup prefix.
* php-repl.el (php-send-region): Use inferior php buffer, not sql buffer.
The binary wrapper /scripts/php-repl will now if the environment variable PHP_INCLUDE_PATH is set and add it to the include_path php.ini directive.
…c66f4a150d Add check for PHP_INCLUDE_PATH environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Just pushed some fixes for php-repl.el to make it work on my Linux box. The comments in the commits should be sufficient to explain the changes.
Best,
-- David