Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add section on as-provided keys #514

Merged
merged 1 commit into from
Oct 23, 2023
Merged

add section on as-provided keys #514

merged 1 commit into from
Oct 23, 2023

Conversation

jricher
Copy link
Collaborator

@jricher jricher commented Oct 18, 2023

No description provided.

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for gnap-core-protocol-editors-draft ready!

Name Link
🔨 Latest commit 3388b93
🔍 Latest deploy log https://app.netlify.com/sites/gnap-core-protocol-editors-draft/deploys/65305d4c46fee10009c9a829
😎 Deploy Preview https://deploy-preview-514--gnap-core-protocol-editors-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jricher jricher merged commit 4126cfc into main Oct 23, 2023
4 checks passed
@yaronf
Copy link
Contributor

yaronf commented Oct 26, 2023

Commenting on a merged PR: please also add a warning where the key attribute is defined, with a reference to this new section.

@jricher
Copy link
Collaborator Author

jricher commented Oct 26, 2023

@yaronf good call, we forgot to put in a proper forward reference -- I'll go add that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants