AD Review Text Updates #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gnap-core-protocol-editors-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fimbault
reviewed
Oct 9, 2023
draft-ietf-gnap-core-protocol.md
Outdated
| @@ -1431,7 +1431,8 @@ its capabilities and what is allowed to fulfill the request. | |||
|
|
|||
| In this non-normative example, the client instance is indicating that it can [redirect](#request-interact-redirect) | |||
| the end user to an arbitrary URI and can receive a [redirect](#request-interact-callback-redirect) through | |||
| a browser request. | |||
| a browser request. Note that the client instance does not accept a push-style callback. This pattern | |||
| is common for web-based client software. | |||
There was a problem hiding this comment.
I would clarify "This redirect pattern" (to make sure we don't misunderstand with the note on push style callback that comes just before)
fimbault
approved these changes
Oct 9, 2023
jricher
commented
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update text based on AD review of core specification:
https://mailarchive.ietf.org/arch/msg/txauth/9Z-nHJsHEDhREiXFl1hDatizb7Q/