fix: Remove emphasis from xref in headings and fix xrefs in headings #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesara
force-pushed
the
fix/name-xref
branch
from
2d41fc1
to
b41b267
Compare
kesara
changed the title
kesara
force-pushed
the
fix/name-xref
branch
from
b41b267
to
57f0ce3
Compare
|
See #683 (comment) for examples. |
This change removes emphasis on xref content in headings. This change also adds xref content to name when the format="none" in the xref element. Fixes ietf-tools#683
When `xref` is in `title`, if `xref` has a target to a `reference` use
square brackets (`[ <target text> ]`).
If the `xref` target is not a reference don't use brackets or parenthesis.
If `xref` element has text content:
For `reference` targets:
`<text content> [<target>]`
For other targets:
`<text content> (<target>)`
kesara
force-pushed
the
fix/name-xref
branch
from
7d36439
to
315fda4
Compare
rjsparks
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xrefcontent tonamewhen theformat="none"in thexrefelement.xrefis intitle, ifxrefhas a target to areferenceusesquare brackets (
[ <target text> ]).xreftarget is not a reference don't use brackets or parenthesis.xrefelement has text content:For
referencetargets:<text content> [<target>]For other targets:
<text content> (<target>)Fixes #683