Skip to content

Commit

Permalink
chore: Restrict WeasyPrint versions (#1038)
Browse files Browse the repository at this point in the history
WeasyPrint==60.0 is breaking tests.
Until we figure out the issues restrict WeasyPrint==60.0.
  • Loading branch information
kesara authored Sep 27, 2023
1 parent c10a50c commit b6bdd70
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
echo "Installing pip + wheel..."
python -m pip install --upgrade pip wheel
echo "Installing requirements.txt + test dependencies..."
python -m pip install -r requirements.txt tox tox-gh-actions certifi decorator dict2xml pyflakes "pypdf>=3.2.1" "weasyprint>=53.0,!=57.0"
python -m pip install -r requirements.txt tox tox-gh-actions certifi decorator dict2xml pyflakes "pypdf>=3.2.1" "weasyprint>=53.0,!=57.0,<60.0"
- name: Generate Valid Tests
run: |
Expand Down Expand Up @@ -151,7 +151,7 @@ jobs:
echo "Installing pip + wheel..."
python -m pip install --upgrade pip wheel
echo "Installing requirements.txt + test dependencies..."
python -m pip install -r requirements.txt tox tox-gh-actions certifi decorator dict2xml pyflakes "pypdf>=3.2.1" "weasyprint>=53.0,!=57.0"
python -m pip install -r requirements.txt tox tox-gh-actions certifi decorator dict2xml pyflakes "pypdf>=3.2.1" "weasyprint>=53.0,!=57.0,<60.0"
- name: Generate Valid Tests
run: |
Expand Down Expand Up @@ -201,7 +201,7 @@ jobs:
# echo "Installing pip + wheel..."
# python -m pip install --upgrade pip wheel
# echo "Installing requirements.txt + test dependencies..."
# python -m pip install -r requirements.txt tox tox-gh-actions certifi decorator dict2xml pyflakes "pypdf>=3.2.1" "weasyprint>=53.0,!=57.0"
# python -m pip install -r requirements.txt tox tox-gh-actions certifi decorator dict2xml pyflakes "pypdf>=3.2.1" "weasyprint>=53.0,!=57.0,<60.0"
# - name: Generate Valid Tests
# run: |
# make yestests || true
Expand Down
2 changes: 1 addition & 1 deletion docker/base.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ RUN pip3 install --upgrade \

# Install Python dependencies
RUN pip3 install -r requirements.txt \
"weasyprint>=53.0" \
"weasyprint>=53.0,<60.0" \
decorator \
dict2xml \
"pypdf>=3.2.1"
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ console_scripts =
xml2rfc = xml2rfc.run:main

[options.extras_require]
pdf = weasyprint>=53.0,!=57.0
pdf = weasyprint>=53.0,!=57.0,<60.0

[bdist_wheel]
universal = 1
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ deps =
decorator
dict2xml
pypdf>=3.2.1
weasyprint>=53.0,!=57.0
weasyprint>=53.0,!=57.0,<60.0
2 changes: 1 addition & 1 deletion xml2rfc/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def get_pdf_help(missing_libs=""):
2. Next, install weasyprint python modules using pip.
pip install 'weasyprint>=53.0'
pip install 'weasyprint>=53.0,<60.0'
3. Finally, install the full Noto Font and Roboto Mono packages:
Expand Down

0 comments on commit b6bdd70

Please sign in to comment.