Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Handle missing environment variables for local dev #433

Merged
merged 4 commits into from
Jul 8, 2024
Merged

chore: Handle missing environment variables for local dev #433

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7079d7
docs: Rename HOST environment variable to HOST_NAME
microamp Jul 7, 2024
6727e1a
chore: Make SOURCE_REPO_URL optional
microamp Jul 7, 2024
8a376c7
Revert "chore: Make SOURCE_REPO_URL optional"
microamp Jul 8, 2024
e07b7aa
docs: Add SOURCE_REPO_URL to .env
microamp Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ services:
PRIMARY_HOSTNAME: ${HOST_NAME?missing main hostname (e.g., localhost for development)}
INTERNAL_HOSTNAMES: "web"
DEBUG: ${DEBUG:-0}
SOURCE_REPO_URL: ${SOURCE_REPO_URL:?missing source repository URL}
SOURCE_REPO_URL: ${SOURCE_REPO_URL}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to have a safeguard because SOURCE_REPO_URL is required for the proper functionality of the services.

DJANGO_SECRET: "${DJANGO_SECRET:?missing Django secret (long random string)}"
API_SECRET: "${API_SECRET:?missing API secret}"
EXTRA_API_SECRETS: "${EXTRA_API_SECRETS}"
Expand Down
2 changes: 1 addition & 1 deletion docs/howto/develop-locally.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Building base image
DB_NAME=bibxml
DB_SECRET=qwert
DJANGO_SECRET=FDJDSLJFHUDHJCTKLLLCMNII(****#TEFF
HOST=localhost
HOST_NAME=localhost
API_SECRET=test
SERVICE_NAME=IETF BibXML service
CONTACT_EMAIL=<ops contact email>
Expand Down
Loading