IMPB-1510 Listings imported with IMPress Listings do not include the MLS disclaimer #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmation from the api when importing listings the idx-api.php client_properties() function adds ?disclaimers=true to all requests made through it, so including ?disclaimers=true in the initial request results in our API not including the disclaimer when it returns results
since this data originates from our API and is never modified by the user, it should be fine to output it directly to the page
… when there are more than 50 featured listings on an account the next value returned by the api does not include disclaimers=true even if it's included in the initial request, so it needs to be added back if a subsequent query needs to be made to fetch all the listings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests
Please explain the intent of your Pull Request.
🐛 Are you fixing a bug? Y
Template
Description of the Change
wp_listings_idx_create_post() erroneously includes ?disclaimers=true when requesting listing information from the API to import listings into a site. Since the client_properties() function in idx-api.php appends ?disclaimers=true to requests made through it, this results in an API call like /clients/featured?disclaimers=true?disclaimers=true being sent which will not return listing information with a disclaimer.
Verification Process
Import a listing through IMPress listings with and without the fix in place.
Release Notes
Fix: Better include MLS disclaimer when importing listings with IMPress listings
Review
Pull Requests must have the sign-off of two other developers and at least one of these must be an IDX Broker team member.