IMPB-1509 correct typo in find_and_update_post() to properly compare post slug and link url when updating IDX pages #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests
🐛 Are you fixing a bug? Y
Template
Description of the Change
Fix typo in find_and_update_post() to properly compare the page slug with the url of an IDX page when IDX pages are updated by IMPress
Verification Process
Run the 3.1.0 version plugin with and without the fix with an instance of a WordPress site that has duplicate posts for an IDX page and observe that with the fix in place the IDX page with a page slug that matches the url of the IDX page is retained, while without the fix in place the oldest IDX page is retained instead.
Release Notes
N/A
Review
Pull Requests must have the sign-off of two other developers and at least one of these must be an IDX Broker team member.