Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve layout selector middleware #344

Merged
merged 1 commit into from
Aug 11, 2024
Merged

feat: improve layout selector middleware #344

merged 1 commit into from
Aug 11, 2024

Conversation

chenshenhai
Copy link
Member

  • feat(core): improve layout selector middleware
  • fix(idraw): fix internal typings of IDrawEvent

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 7.33%. Comparing base (f17790c) to head (2b56320).
Report is 142 commits behind head on main.

Files Patch % Lines
...kages/core/src/middleware/layout-selector/index.ts 0.00% 21 Missing and 9 partials ⚠️
...ages/core/src/middleware/layout-selector/config.ts 0.00% 3 Missing ⚠️
packages/core/src/middleware/selector/index.ts 0.00% 2 Missing and 1 partial ⚠️
packages/core/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #344      +/-   ##
========================================
- Coverage   7.34%   7.33%   -0.02%     
========================================
  Files        113     113              
  Lines       7187    7197      +10     
  Branches    1418    1422       +4     
========================================
  Hits         528     528              
- Misses      5309    5315       +6     
- Partials    1350    1354       +4     
Flag Coverage Δ
unittests 7.33% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenshenhai chenshenhai merged commit 2ce3d17 into main Aug 11, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant