Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check issue remains fixed #117

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Check issue remains fixed #117

merged 3 commits into from
Apr 29, 2020

Conversation

idontgetoutmuch
Copy link
Owner

Checks that haskell#53 remains fixed

curiousleo
curiousleo reviewed Apr 29, 2020
View reviewed changes
Copy link
Collaborator

@curiousleo curiousleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear to me how we avoid these issues, given that we're not doing anything sophisticated with floating point ranges.

Still, this is definitely good to have. I've added a few comments.

test/Spec.hs Outdated Show resolved Hide resolved
test/Spec.hs Outdated Show resolved Hide resolved
@idontgetoutmuch
Copy link
Owner Author

I am going to merge as it just beefs up testing.

@idontgetoutmuch idontgetoutmuch merged commit 22a374e into interface-to-performance Apr 29, 2020
@idontgetoutmuch idontgetoutmuch deleted the unit-tests branch April 29, 2020 13:16
curiousleo pushed a commit that referenced this pull request May 19, 2020
@idontgetoutmuch @curiousleo
Merge pull request #117 from idontgetoutmuch/unit-tests
2dce386 
Check issue remains fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curiousleo curiousleo curiousleo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idontgetoutmuch @curiousleo